Alan Cox wrote:
On Mon, 1 Dec 2008 15:49:25 -0800
David Daney <ddaney@xxxxxxxxxxxxxxxxxx> wrote:
In serial8250_isa_init_ports(), the port's lock is initialized. We
should not overwrite it. In early_serial_setup(), only copy in the
fields we need. Since the early console code only uses a subset of
the fields, these are sufficient.
- serial8250_ports[port->line].port.ops = &serial8250_pops;
You seem to drop the assignment of port.ops ?
The port.ops are initialized in the preceding call to
serial8250_isa_init_ports(), we don't have to set it again as we are no
longer clobbering it with a full structure assignment.
Perhaps the patch commentary should be adjusted to mention this.
David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
