On Tue, Nov 25, 2008 at 06:51:44PM +0800, Sheng Yang wrote: > The logic here is strange... > > If you used old compiler, you would get a warning, and you thought that's > ensured we won't delete a intended assignment by mistake. > > If you used new compiler, you wouldn't get a warning, and you think this time > the compiler get it right. The new compiler gets it right. If you delete the assignment with the new compiler, *then* you get a warning. > OK. if you worry about "delete a line which does the intended assignment", the > updated version with BUG_ON(i == NULL) can help. Compile-time error detection is better than runtime. OG. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html