On Thu, 20 Nov 2008 15:01:23 +0100 Arnd Bergmann <arnd@xxxxxxxx> wrote: > This patch adds support for the nwp serial device which is connected to > a DCR bus. It uses the of_serial device driver to determine necessary > properties from the device tree. The supported device is added as serial > port number 84. checkpatch has a decent whine over this. Some of those things you might decide to ignore, other things tell me that you never ran it anyway... I'd suggest that nwpserial_pops and nwpserial_reg be marked const, as they don't need to be in read/write storage. Except that doesn't work because the kernel isn't very const-competent. Ho hum. (does a powerpc allmodconfig) drivers/serial/nwpserial.c:443: warning: data definition has no type or storage class drivers/serial/nwpserial.c:443: warning: type defaults to 'int' in declaration of 'console_initcall' drivers/serial/nwpserial.c:443: warning: parameter names (without types) in function declaration drivers/serial/nwpserial.c:400: warning: 'nwpserial_console_init' defined but not used The file fails to include linux/init.h. It should do so, but that doesn't fix the above. Apparently it hasn't been tested as a kernel module... -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
