> hlist_for_each() can execute that loop zero times, in which case > serial_unlink_irq_chain will dereference an uninitialised variable. > > Presumably the list shouldn't be empty at this stage, but this > is not particularly robust behaviour if that should happen.. And the only cases that can trip are the more important BUG_ON() checks. You could remove the BUG_ON() calls and make it less robust but that seems slightly well silly to me ? Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html