Hi,
I do the same
port->dev = &dev->dev;
But I am not sure &dev->dev points to the parent. I think it points to
the device it's self, but I may be wrong. I have tried port->dev =
&dev->dev as well as port->dev = dev->dev.parent. One of these found
something when the port was TTYS0 but did not work when the port was
TTYS2.
Did you test with a non zero port->line. I working on ttyS2.
Just trying to narrow down what could be wrong. It just that
tty_dev = device_find_child(port->dev, &match, serial_match_port);
is returning NULL for me.
Thank You for your help.
Vipul
PS. One quick suggestion you may want to check the return value and
verify it is non-NULL before using it. Makes it easier to debug the
code. ...
-----Original Message-----
From: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
To: vcgandhi1@xxxxxxx
Cc: linux-serial@xxxxxxxxxxxxxxx
Sent: Wed, 16 Apr 2008 4:11 pm
Subject: Re: Change to serial_core.c .... causing my serial driver
problem Help Request
On Tue, 15 Apr 2008, vcgandhi1@xxxxxxx wrote:
I think the issue is when the serial port is embedded and not
connected
through the bus. So I am talking about the drivers in the
kernel/drivers/serial directory. A few of them use suspend and resume
and I
think they may not be compatible with your change.
Which specific driver do you see the problem with? I cannot check all
drivers. I took as an example mpc52xx_uart.c. And I see there
port->dev = &dev->dev;
in its ->probe, so, it shouldn't have a problem either.
Do you know if you anybody tested any serial ports that are located
in that
directory and use the suspend and resume calls. Ports not connected
through
the pci bus.
No, I don't know.
Thanks
Guennadi
---
Guennadi Liakhovetski
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
