On Thu, 29 Nov 2007 17:23:14 +0100 Jesper Nilsson <jesper.nilsson@xxxxxxxx> wrote: > +static void serial_cris_set_mctrl(struct uart_port *port, unsigned int mctrl) > +{ > + struct uart_cris_port *up = (struct uart_cris_port *)port; use container_of() here > +static irqreturn_t dma_tr_interrupt(int irq, void *dev_id) > +{ > + struct uart_cris_port *up = (struct uart_cris_port *)dev_id; This driver is a somewhat depressing read too. - To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html