[PATCH] serial/8250_pci: Fix a warning in pciserial_resume_one

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Fix the following warning:
drivers/serial/8250_pci.c: In function "pciserial_resume_one":
drivers/serial/8250_pci.c:1998: warning: ignoring return value of "pci_enable_device", declared with attribute warn_unused_result

Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
---
As a side note, I'm curious why the call to pci_enable_device() is
conditioned by priv being set. I'm also not sure if additional cleanups
should be performed if an error occurs.

 drivers/serial/8250_pci.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--- linux-2.6.24-rc1.orig/drivers/serial/8250_pci.c	2007-10-24 09:59:47.000000000 +0200
+++ linux-2.6.24-rc1/drivers/serial/8250_pci.c	2007-10-24 12:03:26.000000000 +0200
@@ -1987,6 +1987,7 @@ static int pciserial_suspend_one(struct 
 static int pciserial_resume_one(struct pci_dev *dev)
 {
 	struct serial_private *priv = pci_get_drvdata(dev);
+	int rc;
 
 	pci_set_power_state(dev, PCI_D0);
 	pci_restore_state(dev);
@@ -1995,7 +1996,9 @@ static int pciserial_resume_one(struct p
 		/*
 		 * The device may have been disabled.  Re-enable it.
 		 */
-		pci_enable_device(dev);
+		rc = pci_enable_device(dev);
+		if (rc)
+			return rc;
 
 		pciserial_resume_ports(priv);
 	}


-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux