On Wed 2007-08-08 15:41:30, Andrew Morton wrote: > On Wed, 8 Aug 2007 18:35:35 -0400 > Andres Salomon <dilinger@xxxxxxxxxx> wrote: > > > Currently, there's a CONFIG_DISABLE_CONSOLE_SUSPEND that allows one to stop > > the serial console from being suspended when the rest of the machine goes > > to sleep. This is incredibly useful for debugging power management-related > > things; however, having it as a compile-time option has proved to be > > incredibly inconvenient for us (OLPC). There are plenty of times that we > > want serial console to not suspend, but for the most part we'd like serial > > console to be suspended. > > > > This drops CONFIG_DISABLE_CONSOLE_SUSPEND, and replaces it with a kernel > > boot parameter (no_console_suspend). By default, the serial console will > > be suspended along with the rest of the system; by passing > > 'no_console_suspend' to the kernel during boot, serial console will remain > > alive during suspend. > > > > I have another version of this patch which keeps #ifdefs around; however, > > it's uglier. I prefer this version of the patch, and don't feel that it > > increases bloat. If people strongly disagree, let me know and I'll submit > > the other patch. > > > > yep, compile-time options suck. Run-time options suck, too, for stuff that should not be optional; we should keep console live if the console driver can handle it, not otherwise. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html