On Sunday 05 August 2007, Guennadi Liakhovetski wrote: > That would be a possibility, but that would mean all 8241/8245 have to > adjust their .dts. Ok, there are not so many of them in the mainline now > (in fact, hardly any apart from linkstation:-)), still. Cannot we use > something already available to just check if we're running on such a CPU? > Worst case - find and parse cpu node, or maybe using some cpu_feature? It's fundamentally a property of the serial controller implementation, not of the processor, so the cpu_features are the wrong place to put this. There should at least be a generic way to define thsi in the device tree so that _future_ trees can just mark the port as compatible with one that has this bug. If you want to work around existing systems that don't mention this in the device_tree, you could perhaps use machine_is(foo) to test for it. Another option altogether would be to allow the device node to specify the linux specific serial port flags in a separate property, like "linux,uart-port-flags" that contains the same flags that setserial can set from user space. That would also be useful if you want to specify UPF_MAGIC_MULTIPLIER on certain high-speed ports, because it cannot be autoprobed. Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
