Chris Snook writes: > Clean up whitespace and comments in drivers/serial/icom.c These changes seem totally unnecessary, as the existing indentation is according to a commonly-accepted style and is quite reasonable: > @@ -149,23 +149,23 @@ static void free_port_memory(struct icom > trace(icom_port, "RET_PORT_MEM", 0); > if (icom_port->recv_buf) { > pci_free_consistent(dev, 4096, icom_port->recv_buf, > - icom_port->recv_buf_pci); > + icom_port->recv_buf_pci); > icom_port->recv_buf = NULL; > } > if (icom_port->xmit_buf) { > pci_free_consistent(dev, 4096, icom_port->xmit_buf, > - icom_port->xmit_buf_pci); > + icom_port->xmit_buf_pci); etc. etc. The comment changes I agree on but not most of the other whitespace changes. Also you don't seem to have cc'd the driver author. Paul. - To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html