Hi, In 8250.c is_real_interrupt is defined like this: /* * We default to IRQ0 for the "no irq" hack. Some * machine types want others as well - they're free * to redefine this in their header file. */ #define is_real_interrupt(irq) ((irq) != 0) on my platform the UART IRQ is 0, so is_real_interrupt returns false. In order to allow machines to override is_real_interrupt, and for the code to match the comment shouldn't this patch be applied? --- 8250.c.orig 2006-11-29 09:33:47.000000000 -0800 +++ 8250.c 2006-11-29 09:42:51.000000000 -0800 @@ -75,7 +75,9 @@ * machine types want others as well - they're free * to redefine this in their header file. */ +#ifndef is_real_interrupt #define is_real_interrupt(irq) ((irq) != 0) +#endif /* * This converts from our new CONFIG_ symbols to the symbols Thanks --dan - To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html