On Wed, Oct 11, 2006 at 09:47:20PM -0400, Jeff Garzik wrote: > Signed-off-by: Jeff Garzik <jeff@xxxxxxxxxx> NAK. What happens to the ports if pci_enable_device() fails and someone has them open? It's far better to leave the must_check warning behind until it can be _correctly_ solved, rather than papering over the problem with bogus patches to return errors without taking an appropriate additional action. IOW, the warnings serve as a reminder that *proper* error handling needs to be implemented. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html