Hi, I was fixing request_region() error checks and realized few things about mxser driver (char/mxser.c) - I want to confirm before fixing them. 1) mxser_get_PCI_conf() and mxser_get_ISA_conf() doesn't check errors of request_region(). I think these should be checked and return failures. Can we treat request_region() failures as corresponding MXSER_ERR_* failures, instead of returning new error code (like -EIO)? 2) mxser_get_PCI_conf() currently doesn't return error - but the caller checks for various error codes. Is this a oversight or it can't happen with PCI ? If so, can we nix error checking at the caller ? Thanks, Badari - To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
