On Wed, May 10, 2006 at 05:39:19PM +0100, Russell King wrote: > On Fri, May 05, 2006 at 06:15:37PM -0400, George G. Davis wrote: > > @@ -2068,6 +2076,10 @@ uart_configure_port(struct uart_driver * > > > > uart_report_port(drv, port); > > > > + /* Power up port for set_mctrl() */ > > + if (!uart_console(port)) > > + uart_change_pm(state, 0); > > + > > If it's possible for uarts to be powered down here, wouldn't it be a > good idea to ensure that the console is also powered up? Hrm, yes. The above !uart_console(port) merely assumed that the device is already powered up if it's the selected console. In that way we only call uart_change_pm() to power it up once, earlier but I haven't verified that it was indeed done properly. That check can be removed I guess. Thanks! -- Regards, George - To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html