On Fri, Aug 02, 2019 at 04:19:32PM -0700, David Miller wrote: > From: Joe Perches <joe@xxxxxxxxxxx> > Date: Fri, 02 Aug 2019 10:47:34 -0700 > > > On Wed, 2019-07-31 at 08:16 -0400, Neil Horman wrote: > >> On Wed, Jul 31, 2019 at 04:32:43AM -0700, Joe Perches wrote: > >> > On Wed, 2019-07-31 at 07:19 -0400, Neil Horman wrote: > >> > > On Tue, Jul 30, 2019 at 10:04:37PM -0700, Joe Perches wrote: > >> > > > fallthrough may become a pseudo reserved keyword so this only use of > >> > > > fallthrough is better renamed to allow it. > > > > Can you or any other maintainer apply this patch > > or ack it so David Miller can apply it? > > I, like others, don't like the lack of __ in the keyword. It's kind of > rediculous the problems it creates to pollute the global namespace like > that and yes also inconsistent with other shorthands for builtins. > FWIW, I acked the sctp patch, because the use of the word fallthrough as a label, isn't that important to me, unhendled is just as good, so I'm ok with that change. But, as I stated in the other thread, I agree, making a macro out of fallthrough without clearly naming it using a macro convention like __ is not something I'm ok with Neil
