On Fri, Jan 18, 2019 at 11:35:34AM -0200, Marcelo Ricardo Leitner wrote: > On Fri, Jan 18, 2019 at 08:10:22AM -0500, Neil Horman wrote: > > On Tue, Jan 15, 2019 at 12:29:26PM -0200, Marcelo Ricardo Leitner wrote: > > > On Mon, Dec 17, 2018 at 04:00:21PM -0500, Kent Overstreet wrote: > > > > On Mon, Dec 17, 2018 at 12:50:01PM -0800, Andrew Morton wrote: > > > > > On Mon, 17 Dec 2018 08:19:28 -0500 Kent Overstreet <kent.overstreet@xxxxxxxxx> wrote: > > > > > > > > > > > @@ -535,9 +470,6 @@ int sctp_send_add_streams(struct sctp_association *asoc, > > > > > > goto out; > > > > > > } > > > > > > > > > > > > - stream->incnt = incnt; > > > > > > - stream->outcnt = outcnt; > > > > > > - > > > > > > asoc->strreset_outstanding = !!out + !!in; > > > > > > > > > > > > > > > > I'm seeing a reject here for some reason. Using todays's linux-next, > > > > > but there are no changes against net/sctp/stream.c in -next. The > > > > > assignment to stream->incnt has disappeared. I did this: > > > > > > > > > > @@ -535,8 +470,6 @@ int sctp_send_add_streams(struct sctp_as > > > > > goto out; > > > > > } > > > > > > > > > > - stream->outcnt = outcnt; > > > > > - > > > > > asoc->strreset_outstanding = !!out + !!in; > > > > > > > > > > out: > > > > > > > > > > > > > > > We're at 4.20-rc7 and this series is rather large. I'll merge them all > > > > > to see what happens, but I don't think it's 4.21-rc1 material? > > > > > > > > Yeah, agreed. Thanks! > > > > > > Ping? Where did this go? > > > > > As I recall kent reposted his series convirting flex_arrays to radix trees such > > that it included sctp's uses. > > That should be this patchset already. Or you mean another (re)post, > v2 or so? If yes then I missed it somehow but I still see the > flex_array in v5.0-rc2: > > net-next]$ git ls-tree v5.0-rc2 -- lib/flex_array.c > 100644 blob 2eed22fa507c7cb0756d7ef643f8a3454eb455ec lib/flex_array.c > > and missing the convertion on sctp stack. > > Current patch is the only one I could find with sctp being included: > https://lore.kernel.org/lkml/20181217210021.GA7144@kmo-pixel/T/#re4f8656af37431a376044399681a8771375a4405 > Correct, and it doesn't seem to be included yet, though I acked Kents patch as I recall. not sure what the hold up is at this point Neil > > > > I think xin needs to repost the sctp reallocation patch to make use of those > > radix trees appropriately still (assuming any additional work still needs to be > > done) > > This came up on another converstation with him and the lack of this > convertion is blocking him on at least one fix, on one that the fix > using flex_arrays is one and genradix is another. > > Marcelo > > > > > Neil > > > > > Marcelo > > > >
