From: Daniel Borkmann <dborkman@xxxxxxxxxx> Date: Mon, 10 Nov 2014 18:00:09 +0100 > A very minimal and simple user space application allocating an SCTP > socket, setting SCTP_AUTH_KEY setsockopt(2) on it and then closing > the socket again will leak the memory containing the authentication > key from user space: ... > This is bad because of two things, we can bring down a machine from > user space when auth_enable=1, but also we would leave security sensitive > keying material in memory without clearing it after use. The issue is > that sctp_auth_create_key() already sets the refcount to 1, but after > allocation sctp_auth_set_key() does an additional refcount on it, and > thus leaving it around when we free the socket. > > Fixes: 65b07e5d0d0 ("[SCTP]: API updates to suport SCTP-AUTH extensions.") > Signed-off-by: Daniel Borkmann <dborkman@xxxxxxxxxx> > Cc: Vlad Yasevich <vyasevich@xxxxxxxxx> Also applied and queued up for -stable, thanks again. -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html