From: Daniel Borkmann <dborkman@xxxxxxxxxx> Date: Sat, 12 Jul 2014 20:30:35 +0200 > While working on some other SCTP code, I noticed that some > structures shared with user space are leaking uninitialized > stack or heap buffer. In particular, struct sctp_sndrcvinfo > has a 2 bytes hole between .sinfo_flags and .sinfo_ppid that > remains unfilled by us in sctp_ulpevent_read_sndrcvinfo() when > putting this into cmsg. But also struct sctp_remote_error > contains a 2 bytes hole that we don't fill but place into a skb > through skb_copy_expand() via sctp_ulpevent_make_remote_error(). ... > Fix this by setting both to 0 before filling them out. We also > have other structures shared between user and kernel space in > SCTP that contains holes (e.g. struct sctp_paddrthlds), but we > copy that buffer over from user space first and thus don't need > to care about it in that cases. > > While at it, we can also remove lengthy comments copied from > the draft, instead, we update the comment with the correct RFC > number where one can look it up. > > Signed-off-by: Daniel Borkmann <dborkman@xxxxxxxxxx> Applied to 'net' and queued up for -stable. I'll get to the rest of this series after I next merge net into net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
