On Tue, Apr 16, 2013 at 11:07:13PM +0200, Daniel Borkmann wrote: > sctp_outq structure members fast_rtx, cork and empty are all > of type char. Consolidate them into a single __u8 bitfield since > they either carry 0 or 1. Have the rest 5 bits for future flags. > > Signed-off-by: Daniel Borkmann <dborkman@xxxxxxxxxx> > --- > include/net/sctp/structs.h | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h > index 73fd5de..3de5985 100644 > --- a/include/net/sctp/structs.h > +++ b/include/net/sctp/structs.h > @@ -1051,14 +1051,9 @@ struct sctp_outq { > /* How many unackd bytes do we have in-flight? */ > __u32 outstanding_bytes; > > - /* Are we doing fast-rtx on this queue */ > - char fast_rtx; > - > - /* Corked? */ > - char cork; > - > - /* Is this structure empty? */ > - char empty; > + __u8 fast_rtx:1, /* Are we doing fast-rtx on this queue */ > + cork:1, /* Corked? */ > + empty:1; /* Is this structure empty? */ > }; > > void sctp_outq_init(struct sctp_association *, struct sctp_outq *); > -- > 1.7.11.7 > Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html