Re: NULL primary_path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 07, 2013 at 04:51:18PM -0500, Karl Heiss wrote:
> On Thu, Mar 7, 2013 at 12:17 PM, Vlad Yasevich <vyasevich@xxxxxxxxx> wrote:
> > On 03/07/2013 12:06 PM, Karl Heiss wrote:
> >>
> >> The issue appears to manifest itself when the connection is closed
> >> from the remote end and getsockopt(SCTP_STATUS) is called within a
> >> small window in which the association is still valid but
> >> asoc->peer.primary_path is NULL.
> >
> >
> > Aha!  Thanks.  There was a bug in the rcu clean-up that allowed the
> > association to remain while all transports have been removed.
> >
> > Here is a patch that should have addressed this condition:
> >
> > commit 8c98653f05534acd1cb07ea4929702a3659177d1
> > Author: Daniel Borkmann <dborkman@xxxxxxxxxx>
> > Date:   Fri Feb 1 04:37:43 2013 +0000
> >
> >     sctp: sctp_close: fix release of bindings for deferred call_rcu's
> >
> > Full patch is here:
> > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=8c98653f05534acd1cb07ea4929702a3659177d1
> >
> > Make sure that you have this patch in the kernel you are running
> >
> > -vlad
> >
> >
> >>
> 
> Unfortunately this patch wont apply to the version of the SCTP stack
> that we are using (2.6.36.2) since it does not have a
> sctp_transport_destroy_rcu() function.  Is there any chance that
> simply swapping the order of the instructions without moving them
> would have any effect?  I ask this hypothetically because the race
> condition window seems to be difficult to recreate, thus nothing to
> test against (aside from in the field!).
> 
> Karl

you also need to backport comit 45122ca26ced7fae41049326a3797a73f961db2e.  You
may also need to massage these patches manually somewhat so that they apply
properly.
Neil

> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux