On Thu, Dec 06, 2012 at 03:07:20PM -0500, Vlad Yasevich wrote:
> On 12/06/2012 02:25 PM, Thomas Graf wrote:
> >From: Thomas Graf <tgraf@xxxxxxxxxx>
> >
> >address_list is protected via the socket lock or RCU. Since we don't want
> >to take the socket lock for each assoc we dump in procfs a RCU read-side
> >critical section must be entered.
> >
> >V2: Skip local addresses marked as dead
> >
> >Cc: Vlad Yasevich <vyasevich@xxxxxxxxx>
> >Cc: Neil Horman <nhorman@xxxxxxxxxxxxx>
> >Signed-off-by: Thomas Graf <tgraf@xxxxxxx>
>
> Acked-by: Vlad Yasevich <vyasevic@xxxxxxxxx>
>
> -vlad
>
Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx>
> >---
> > net/sctp/proc.c | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> >diff --git a/net/sctp/proc.c b/net/sctp/proc.c
> >index 9966e7b..06b05ee 100644
> >--- a/net/sctp/proc.c
> >+++ b/net/sctp/proc.c
> >@@ -139,7 +139,11 @@ static void sctp_seq_dump_local_addrs(struct seq_file *seq, struct sctp_ep_commo
> > primary = &peer->saddr;
> > }
> >
> >- list_for_each_entry(laddr, &epb->bind_addr.address_list, list) {
> >+ rcu_read_lock();
> >+ list_for_each_entry_rcu(laddr, &epb->bind_addr.address_list, list) {
> >+ if (!laddr->valid)
> >+ continue;
> >+
> > addr = &laddr->a;
> > af = sctp_get_af_specific(addr->sa.sa_family);
> > if (primary && af->cmp_addr(addr, primary)) {
> >@@ -147,6 +151,7 @@ static void sctp_seq_dump_local_addrs(struct seq_file *seq, struct sctp_ep_commo
> > }
> > af->seq_dump_addr(seq, addr);
> > }
> >+ rcu_read_unlock();
> > }
> >
> > /* Dump remote addresses of an association. */
> >
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
