> -----Original Message----- > From: Johannes Thumshirn [mailto:jthumshirn@xxxxxxx] > Sent: Monday, August 29, 2016 4:34 AM > To: Don Brace > Cc: jejb@xxxxxxxxxxxxxxxxxx; Viswas G; Mahesh Rajashekhara; > hch@xxxxxxxxxxxxx; Scott Teel; Kevin Barnett; Justin Lindley; Scott Benesh; > elliott@xxxxxxx; linux-scsi@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 11/17] smartpqi: minor tweaks to update time support > > EXTERNAL EMAIL > > > > > > static inline void pqi_schedule_update_time_worker( > > - struct pqi_ctrl_info *ctrl_info) > > + struct pqi_ctrl_info *ctrl_info) > > { > > - schedule_delayed_work(&ctrl_info->update_time_work, 120); > > + schedule_delayed_work(&ctrl_info->update_time_work, 0); > > } > > Why are you using schedule_delayed_work() if you have a timeout of 0? > From __queue_delayed_work(): > 1513 /* > 1514 * If @delay is 0, queue @dwork->work immediately. This is for > 1515 * both optimization and correctness. The earliest @timer can > 1516 * expire is on the closest next tick and delayed_work users depend > 1517 * on that there's no such delay when @delay is 0. > 1518 */ > 1519 if (!delay) { > 1520 __queue_work(cpu, wq, &dwork->work); > 1521 return; > 1522 } > > > -- > Johannes Thumshirn Storage > jthumshirn@xxxxxxx +49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) > Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 The reason is that we want it run immediately (or close to immediately). The code could be restructured to avoid calling this function with a 0, but it would result in more code and no benefit. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
