> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Tue, 17 Nov 2015 08:14:52 +0100
>
> The kmem_cache_destroy() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the calls is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/scsi/aic94xx/aic94xx_init.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c
> index 662b232..ab93049 100644
> --- a/drivers/scsi/aic94xx/aic94xx_init.c
> +++ b/drivers/scsi/aic94xx/aic94xx_init.c
> @@ -660,12 +660,9 @@ Err:
>
> static void asd_destroy_global_caches(void)
> {
> - if (asd_dma_token_cache)
> - kmem_cache_destroy(asd_dma_token_cache);
> + kmem_cache_destroy(asd_dma_token_cache);
> asd_dma_token_cache = NULL;
> -
> - if (asd_ascb_cache)
> - kmem_cache_destroy(asd_ascb_cache);
> + kmem_cache_destroy(asd_ascb_cache);
> asd_ascb_cache = NULL;
> }
>
>
How do you think about to integrate this update suggestion
into another source code repository?
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
