On 05/16/2016 12:02 PM, Martin K. Petersen wrote:
"Bart" == Bart Van Assche <bart.vanassche@xxxxxxxxxxx> writes:
Bart> That's a good catch. But seeing this patch makes me wonder whether
Bart> this patch introduces a 64-bit division? If so, I'm afraid this
Bart> patch will make 32-bit users unhappy. Have you considered to use
Bart> do_div() or >> (ilog2(block_size) - 9) instead? For the latter
Bart> alternative no 64-bit cast is needed.
Please use logical_to_sectors().
Hello Martin,
For SCSI initiator devices the logical block size is stored in struct
scsi_device. logical_to_sectors() gets the logical block size from
struct scsi_device. LIO however stores the logical block size in struct
se_dev_attrib. If we want to keep SCSI initiator and SCSI target headers
separate I think we will need two logical_to_sectors() functions - one
for SCSI initiator devices and one for SCSI target devices.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
