On 05/16/2016 11:46 AM, mchristi@xxxxxxxxxx wrote:
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index a4046ca..3f9f304 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -826,8 +826,8 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
- attrib->max_unmap_lba_count = (q->limits.max_discard_sectors << 9) /
- block_size;
+ attrib->max_unmap_lba_count =
+ ((u64)q->limits.max_discard_sectors << 9) / block_size;
Hello Mike,
That's a good catch. But seeing this patch makes me wonder whether this
patch introduces a 64-bit division? If so, I'm afraid this patch will
make 32-bit users unhappy. Have you considered to use do_div() or >>
(ilog2(block_size) - 9) instead? For the latter alternative no 64-bit
cast is needed.
Thanks,
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
