>>>>> "Tom" == Tom Yan <tom.ty89@xxxxxxxxx> writes: Tom, Tom> But yeah if it has unmap granularity reported to be, for example, Tom> 16, then it will not be correctly set with min_not_zero(). Tom> Wait, shouldn't it be: Tom> max(sdkp->logical_block_size, sdkp->unmap_granularity * logical_block_size); Tom> then? Let's take the your example of a drive with 512-byte logical blocks and 4096-byte physical blocks. How would a drive partially unmap a sector? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html