Would min_not_zero() be more proper than max()? On 11 March 2016 at 20:37, Martin K. Petersen <martin.petersen@xxxxxxxxxx> wrote: >>>>>> "Tom" == Tom Yan <tom.ty89@xxxxxxxxx> writes: > > Tom, > > Tom> In that case, if the granularity only act as some sort of > Tom> "reference" but has no real "binding" to the actual behaviour, why > Tom> would the kernel even "make up" the granularity itself according to > Tom> the physical block size of the device: > > Tom> q-> limits.discard_granularity = max(sdkp->physical_block_size, > Tom> sdkp-> unmap_granularity * logical_block_size); > > Many devices predate the UNMAP-related fields in the Block Limits > VPD. There are also devices that do not report an OPTIMAL UNMAP > GRANULARITY despite supporting UNMAP. > > -- > Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
