On 02/07/2016 05:04 PM, James Bottomley wrote: > On Sun, 2016-02-07 at 10:22 +0100, Christoph Hellwig wrote: >> Keith said it should be on by default, and I promised him to change >> it once we run into problems, which I guess this counts as. >> >> But just curious: what distro are you using? Upstream systemd >> explicitly rejected using scsi_id for NVMe here: >> >> https://github.com/systemd/systemd/issues/1453 >> >> and all my test systems don't do this either. > > This was SUSE (in my case, openSUSE Leap). I just checked the source > package; they patch the by-id rules back in for NVME: > > # PATCH-FIX-SUSE 1101-rules-persistent-device-names-for-NVMe-devices.patch (bsc#944132) > Patch1101: 1101-rules-persistent-device-names-for-NVMe-devices.patch > > The bugzilla is giving access denied for bug id 944132, so it's likely > some proprietary vendor problem. The patch has no preamble, so it's > hard to tell what they were thinking. > They didn't think at all. That abovementioned bug just states 'by-id symlinks for NVMe drives are missing'. And they fixed it by add the respective rules (using sg_inq) to udev. There's no mentioning of any NVMe specific sysfs attributes whatsoever. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
