>>>>> "Ewan" == Ewan Milne <emilne@xxxxxxxxxx> writes: Ewan> Maybe it's unnecessary, but I would put parenthesis around (ret == Ewan> ... -EIO); for clarity. Sure. Ewan> I would prefer that additional enum/constant values be added to Ewan> the end of the series, here you are changing the ordinal value of Ewan> BLKPREP_DEFER from 2 to 3. Could you swap these? I felt that KILL and INVALID were closely related. That's why I kept them together. But it doesn't matter to me. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
