Hello, James. On Fri, Jan 15, 2016 at 11:09:16AM -0800, James Bottomley wrote: > If we want to change what is being counted, we have to change the > definition, so what is the definition you want to see for counting > errors? and what's the reason driving this change? There isn't anything else to it than what I already wrote. It goes up for things which aren't failures making the counter essentially useless. It's confusing from userland as it's unintuitive that these commands are wrapped in SCSI ATA passthrough commands which use sense data for result reporting and doing equivalent operations on native SCSI and ATA devices lead to different outcomes. The counter as-is is just useless for libata devices. If it can be rectified easily, great. If not, it isn't anything critical. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html