On Thu, Dec 10, 2015 at 8:15 PM, Martin K. Petersen <martin.petersen@xxxxxxxxxx> wrote: >>>>>> "Rasmus" == Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> writes: > > Rasmus> If char is signed and one of these bytes happen to have a value > Rasmus> outside the ascii range, the corresponding output will consist > Rasmus> of "ffffff" followed by the two hex chars that were actually > Rasmus> intended. One way to fix it would be to change the casts to > Rasmus> (u8*) aka (unsigned char*), but it is much simpler (and > Rasmus> generates smaller code) to use the %ph extension which was > Rasmus> created for such short hexdumps. > > Applied to 4.5/scsi-queue. How fast! Martin, I have several patches on SCSI subsytem like this one. Some of them didn't manage kernel (even having Ack!) for years already. Is it okay if I collect them together and send a bunch once again Cc'ing you? -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html