>>>>> "Rasmus" == Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> writes: Rasmus> If char is signed and one of these bytes happen to have a value Rasmus> outside the ascii range, the corresponding output will consist Rasmus> of "ffffff" followed by the two hex chars that were actually Rasmus> intended. One way to fix it would be to change the casts to Rasmus> (u8*) aka (unsigned char*), but it is much simpler (and Rasmus> generates smaller code) to use the %ph extension which was Rasmus> created for such short hexdumps. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html