Re: [PATCH] qla2xxx: Fix regression introduced by configFS changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Himanshu & Co,

On Tue, 2015-11-24 at 12:20 -0500, Himanshu Madhani wrote:
> this patch fixes following regression
> 
>  # targetcli
>  [Errno 13] Permission denied: '/sys/kernel/config/target/qla2xxx/21:00:00:0e:1e:08:c7:20/tpgt_1/enable'
> 
> Fixes: 2eafd72939fd ("target: use per-attribute show and store methods")
> Signed-off-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
> Signed-off-by: Giridhar Malavali <giridhar.malavali@xxxxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
> ---
>  drivers/scsi/qla2xxx/tcm_qla2xxx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
> index 3ba2e95..81af294 100644
> --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
> +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
> @@ -902,7 +902,7 @@ static ssize_t tcm_qla2xxx_tpg_fabric_prot_type_show(struct config_item *item,
>  	return sprintf(page, "%d\n", tpg->tpg_attrib.fabric_prot_type);
>  }
>  
> -CONFIGFS_ATTR_WO(tcm_qla2xxx_tpg_, enable);
> +CONFIGFS_ATTR(tcm_qla2xxx_tpg_, enable);
>  CONFIGFS_ATTR_RO(tcm_qla2xxx_tpg_, dynamic_sessions);
>  CONFIGFS_ATTR(tcm_qla2xxx_tpg_, fabric_prot_type);
>  

Applied to target-pending/master, and including in v4.4-rc fixes PULL.

Thanks for reporting.

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux