On 19/11/2015 09:20, Or Gerlitz wrote:
On 11/16/2015 6:37 PM, Sagi Grimberg wrote:+/** + * struct iser_hello - iSER Hello header + * + * @opcode: opcode (must be set to ISER_HELLO) + * @max_min_ver: maximum and minimum iser versions + * @iser_ird: iSER IRD + * @rsvd: reserved + */ +struct iser_hello { + u8 opcode; + u8 max_min_ver; + u16 iser_ird; + u8 rsvd[20]; +} __packed; + +/** + * struct iser_hello_rep - iSER Hello reply header + * + * @opcode_rej: opcode (must be set to ISER_HELLORPLY) + * lower bit is reject bit + * @max_cur_ver: maximum and current iser versions + * @iser_ord: iSER ORD + * @rsvd: reserved + */ +struct iser_hello_rep { + u8 opcode_rej; + u8 max_cur_ver; + u16 iser_ord; + u8 rsvd[20]; +} __packed; +I don't see the point to include these two defs, we don't use them and Steve even got iser to work over iwarp without them, so why care? we should only leave
It's part of the protocol so I figured it should go here even if it's not used today. I can remove them if you like... -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
