On Tue, 10 Nov 2015, Greg Kroah-Hartman wrote: > On Tue, Nov 10, 2015 at 01:32:10PM -0500, Mikulas Patocka wrote: > > Fix the warning drivers/target/target_core_pr.c:332:3: warning: 'return' > > with no value, in function returning non-void [-Wreturn-type] > > > > The patch 35afa65642a9a88c81913377b93a3a66220f8b9d committed to 4.1.11 > > adds a check if device_list is NULL. The patch adds a return statement > > without a value to the function core_scsi3_pr_seq_non_holder that returns > > int. > > > > Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx> > > > > --- > > drivers/target/target_core_pr.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > <formletter> > > This is not the correct way to submit patches for inclusion in the > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > for how to do this properly. > > </formletter> This patch has no upstream equivalent (because the code in upstream was already refactored), so none of the rules in stable_kernel_rules.txt apply to it. The patch that broke it also has no upstream equivalent. Documentation/stable_kernel_rules.txt --- Option 1 --- To have the patch automatically included in the stable tree, add the tag Cc: stable@xxxxxxxxxxxxxxx in the sign-off area. Once the patch is merged it will be applied to the stable tree without anything else needing to be done by the author or subsystem maintainer. --- Option 2 --- After the patch has been merged to Linus' tree, send an email to stable@xxxxxxxxxxxxxxx containing the subject of the patch, the commit ID, why you think it should be applied, and what kernel version you wish it to be applied to. --- Option 3 --- Send the patch, after verifying that it follows the above rules, to stable@xxxxxxxxxxxxxxx. You must note the upstream commit ID in the changelog of your submission, as well as the kernel version you wish it to be applied to. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html