On Wed, 2015-07-22 at 15:01 -0700, Spencer Baugh wrote:
> From: Joern Engel <joern@xxxxxxxxxxxxxxx>
>
> Make the warning about unsupported SCSI opcode more useful:
>
> - Add in the initiator name so we know who's sending it.
> - Print the warning even for opcodes that spc_parse_cdb() knows about
> but that we don't handle.
>
> Signed-off-by: Joern Engel <joern@xxxxxxxxxxxxxxx>
> Signed-off-by: Spencer Baugh <sbaugh@xxxxxxxxxx>
> ---
> drivers/target/target_core_spc.c | 3 ---
> drivers/target/target_core_transport.c | 5 +++++
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/target/target_core_spc.c b/drivers/target/target_core_spc.c
> index b074443..87d4adb 100644
> --- a/drivers/target/target_core_spc.c
> +++ b/drivers/target/target_core_spc.c
> @@ -1405,9 +1405,6 @@ spc_parse_cdb(struct se_cmd *cmd, unsigned int *size)
> }
> break;
> default:
> - pr_warn("TARGET_CORE[%s]: Unsupported SCSI Opcode"
> - " 0x%02x, sending CHECK_CONDITION.\n",
> - cmd->se_tfo->get_fabric_name(), cdb[0]);
> return TCM_UNSUPPORTED_SCSI_OPCODE;
> }
>
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index ce8574b..ac002a7 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -1246,6 +1246,11 @@ target_setup_cmd_from_cdb(struct se_cmd *cmd, unsigned char *cdb)
> }
>
> ret = dev->transport->parse_cdb(cmd);
> + if (ret == TCM_UNSUPPORTED_SCSI_OPCODE)
> + pr_warn_ratelimited("%s/%s: Unsupported SCSI Opcode 0x%02x, sending CHECK_CONDITION.\n",
> + cmd->se_tfo->get_fabric_name(),
> + cmd->se_sess->se_node_acl->initiatorname,
> + cmd->t_task_cdb[0]);
> if (ret)
> return ret;
>
Applied to target-pending/for-next.
Thanks Joern + Spencer!
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
