On 07/24/2015 04:51 PM, Christoph Hellwig wrote: >> - memset(h->buff, 0, stpg_len); >> - h->buff[4] = TPGS_STATE_OPTIMIZED & 0x0f; >> - h->buff[6] = (h->group_id >> 8) & 0xff; >> - h->buff[7] = h->group_id & 0xff; >> + memset(stpg_data, 0, stpg_len); >> + stpg_data[4] = TPGS_STATE_OPTIMIZED & 0x0f; >> + put_unaligned_be16(group_id, &stpg_data[6]); > > Unrelated get/put_unaligned changes again. > > >> - if (!scsi_normalize_sense(h->sense, SCSI_SENSE_BUFFERSIZE, >> + if (!(driver_byte(retval) & DRIVER_SENSE) || >> + !scsi_normalize_sense(h->sense, SCSI_SENSE_BUFFERSIZE, > > Where does this come from? > Hmm. Probably slipped in during patch rework. I'll be removing it. >> + (!h->pref) && > > > no need for braces here. > OK. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
