Re: [PATCH 06/11] hpsa: cleanup update scsi devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18.7.2015 18:12, Don Brace wrote:
> showing that tables have been updated unnecessarily.
> 
> Reviewed-by: Kevin Barnett <kevin.barnett@xxxxxxxx>
> Reviewed-by: Scott Teel <scott.teel@xxxxxxxx>
> Signed-off-by: Don Brace <don.brace@xxxxxxxx>
Reviewed-by: Tomas Henzl <thenzl@xxxxxxxxxx>

Tomas

> ---
>  drivers/scsi/hpsa.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index f64a2c7..f34978d 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -1379,8 +1379,9 @@ static inline int device_updated(struct hpsa_scsi_dev_t *dev1,
>  		return 1;
>  	if (dev1->offload_enabled != dev2->offload_enabled)
>  		return 1;
> -	if (dev1->queue_depth != dev2->queue_depth)
> -		return 1;
> +	if (!is_logical_dev_addr_mode(dev1->scsi3addr))
> +		if (dev1->queue_depth != dev2->queue_depth)
> +			return 1;
>  	return 0;
>  }
>  
> @@ -3889,7 +3890,6 @@ static void hpsa_update_scsi_devices(struct ctlr_info *h, int hostno)
>  			else if (!(h->transMethod & CFGTBL_Trans_io_accel1 ||
>  				h->transMethod & CFGTBL_Trans_io_accel2))
>  				break;
> -
>  			hpsa_get_ioaccel_drive_info(h, this_device,
>  						lunaddrbytes, id_phys);
>  			hpsa_get_path_info(this_device, lunaddrbytes, id_phys);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux