Re: [PATCH 03/11] hpsa: correct static checker warnings on driver init cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18.7.2015 18:12, Don Brace wrote:
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Reviewed-by: Kevin Barnett <kevin.barnett@xxxxxxxx>
> Reviewed-by: Scott Teel <scott.teel@xxxxxxxx>
> Signed-off-by: Don Brace <don.brace@xxxxxxxx>
Reviewed-by: Tomas Henzl <thenzl@xxxxxxxxxx>

Tomas

> ---
>  drivers/scsi/hpsa.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index e9b2073..6b083af 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -8053,7 +8053,7 @@ reinit_after_soft_reset:
>  		rc = hpsa_kdump_soft_reset(h);
>  		if (rc)
>  			/* Neither hard nor soft reset worked, we're hosed. */
> -			goto clean9;
> +			goto clean7;
>  
>  		dev_info(&h->pdev->dev, "Board READY.\n");
>  		dev_info(&h->pdev->dev,
> @@ -8099,8 +8099,6 @@ reinit_after_soft_reset:
>  				h->heartbeat_sample_interval);
>  	return 0;
>  
> -clean9: /* wq, sh, perf, sg, cmd, irq, shost, pci, lu, aer/h */
> -	kfree(h->hba_inquiry_data);
>  clean7: /* perf, sg, cmd, irq, shost, pci, lu, aer/h */
>  	hpsa_free_performant_mode(h);
>  	h->access.set_intr_mask(h, HPSA_INTR_OFF);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux