On 07/08/2015 05:23 PM, Sagi Grimberg wrote: > On 7/8/2015 6:06 PM, Hannes Reinecke wrote: > >> We're adding extra fields here, so we need to make sure to not >> overflow the buffer. You probably have to pass in the buffersize >> to avoid an overflow ... >> Yeah, I know, it's theoretical at the moment. >> But there's nothing which prevents anyone to add other fields to it, >> so this field might be the one causing the overflow. > > Since this patch is simply a movement of functions I don't think I > should change any functionality here. Would it be acceptable to fix > this in an incremental patch? Sure. So you can add a Reviewed-by: Hannes Reinecke <hare@xxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
