> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Fri, 21 Nov 2014 09:15:10 +0100 > > The dst_release() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > drivers/scsi/cxgbi/libcxgbi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c > index addd1dd..95d2654 100644 > --- a/drivers/scsi/cxgbi/libcxgbi.c > +++ b/drivers/scsi/cxgbi/libcxgbi.c > @@ -798,8 +798,7 @@ void cxgbi_sock_closed(struct cxgbi_sock *csk) > return; > if (csk->saddr.sin_port) > sock_put_port(csk); > - if (csk->dst) > - dst_release(csk->dst); > + dst_release(csk->dst); > csk->cdev->csk_release_offload_resources(csk); > cxgbi_sock_set_state(csk, CTP_CLOSED); > cxgbi_inform_iscsi_conn_closing(csk); > Would you like to integrate this update suggestion into another source code repository? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
