On 07/08/2015 12:49 PM, Christoph Hellwig wrote: > On Wed, Jul 08, 2015 at 01:36:04PM +0300, Sagi Grimberg wrote: >> We don't have any other information today, but sector is not the only >> information that is requires a descriptor format, so maybe it will be a >> bit awkward to condition the descriptor format on the sector info? > > The only reason why you'd want to support descriptor type sense data is > because you need to add a second descriptor. If we have another case > that needs descriptor sense data it'll also need to add that additional > descriptor. So we'll need a conditional for it in the sense data > generation anyway. > Actually it's controlled by the D_SENSE bit in the Control mode page (that's bit[2] of byte 2 in the control mode page). Which is currently set to '0', ie we will be returning fixed sense information. _If_ we were to report descriptor sense we will need to change that, too. And it's actually not true that you'd need descriptor sense to encode the sector information; it'll be stored in the 'information' section (byte 3-6) for fixed format sense. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
