Re: [PATCH v3 4/5] target: Use scsi helpers to build the sense data correctly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> --- a/include/target/target_core_base.h
> +++ b/include/target/target_core_base.h
> @@ -7,6 +7,7 @@
>  #include <linux/blkdev.h>
>  #include <linux/percpu_ida.h>
>  #include <linux/t10-pi.h>
> +#include <scsi/scsi_common.h>
>  #include <net/sock.h>
>  #include <net/tcp.h>

Please only add the include in the files that need it.  (And many of the
existing includes should be fixed up the same way, but that's a
different story).

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux