> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Thu, 20 Nov 2014 20:37:30 +0100 > > The pci_dev_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > drivers/scsi/eata_pio.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/eata_pio.c b/drivers/scsi/eata_pio.c > index 8319d2b..707f64d 100644 > --- a/drivers/scsi/eata_pio.c > +++ b/drivers/scsi/eata_pio.c > @@ -122,8 +122,7 @@ static int eata_pio_release(struct Scsi_Host *sh) > release_region(sh->io_port, sh->n_io_port); > } > /* At this point the PCI reference can go */ > - if (hd->pdev) > - pci_dev_put(hd->pdev); > + pci_dev_put(hd->pdev); > return 1; > } > > Would you like to integrate this update suggestion into another source code repository? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
