re: lpfc: Fix rport leak.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello James Smart,

This is a semi-automatic email about new static checker warnings.

The patch 466e840b7809: "lpfc: Fix rport leak." from May 21, 2015, 
leads to the following Smatch complaint:

drivers/scsi/lpfc/lpfc_hbadisc.c:3905 lpfc_register_remote_port()
	 error: we previously assumed 'rdata' could be null (see line 3903)

drivers/scsi/lpfc/lpfc_hbadisc.c
  3902			ndlp->rport = NULL;
  3903			if (rdata && rdata->pnode == ndlp)
                            ^^^^^
Patch introduces a new check.

  3904				lpfc_nlp_put(ndlp);
  3905			rdata->pnode = NULL;
                        ^^^^^^^^^^^^
Unchecked dereference.

  3906			/* drop reference for earlier registeration */
  3907			put_device(&rport->dev);

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux