Re: [PATCH v2] mptsas: fix depth param in scsi_track_queue_full

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



James,

This patch looks good, please consider this patch as Acked-by:
"Sreekanth Reddy" <Sreekanth.reddy@xxxxxxxxxxxxx>.

Regards,
Sreekanth

On Wed, Jun 3, 2015 at 9:07 PM, Tomas Henzl <thenzl@xxxxxxxxxx> wrote:
> v2: use debug log level to silence the unsurprising information
>
> v1: A user of scsi_track_queue_full should pass to the function
> a constant value untill the queue-depth changes, otherwise the
> internal logic in scsi_track_queue_full rejects the change.
> Other users of this function use a 'sdev->queue_depth - 1'
> as depth parameter, let's do the same.
>
> Signed-off-by: Tomas Henzl <thenzl@xxxxxxxxxx>
> ---
>  drivers/message/fusion/mptsas.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c
> index 551262e4b9..fe8f277567 100644
> --- a/drivers/message/fusion/mptsas.c
> +++ b/drivers/message/fusion/mptsas.c
> @@ -4096,7 +4096,7 @@ mptsas_handle_queue_full_event(struct fw_event_work *fw_event)
>                                         continue;
>                                 }
>                                 depth = scsi_track_queue_full(sdev,
> -                                   current_depth - 1);
> +                                       sdev->queue_depth - 1);
>                                 if (depth > 0)
>                                         sdev_printk(KERN_INFO, sdev,
>                                         "Queue depth reduced to (%d)\n",
> @@ -4106,7 +4106,7 @@ mptsas_handle_queue_full_event(struct fw_event_work *fw_event)
>                                         "Tagged Command Queueing is being "
>                                         "disabled\n");
>                                 else if (depth == 0)
> -                                       sdev_printk(KERN_INFO, sdev,
> +                                       sdev_printk(KERN_DEBUG, sdev,
>                                         "Queue depth not changed yet\n");
>                         }
>                 }
> --
> 1.9.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux