On Mon, 2015-06-01 at 06:43 +0000, Seymour, Shane M wrote: > +#if (BITS_PER_LONG == 64) > +#define PRId64 "ld" > +#else > +#define PRId64 "lld" > +#endif I know this is the windows recommended way to do this, but lets not pollute the kernel with it because the kernel accepts %lld everywhere for 64 bit integers (including on 64 bit platforms). > +/** > + * read_cnt_show - return read count - count of reads made from tape drive > + * @dev: struct device > + * @attr: attribute structure > + * @buf: buffer to return formatted data in > + */ > +static ssize_t read_cnt_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct st_modedef *STm = dev_get_drvdata(dev); > + > + return sprintf(buf, "%"PRId64, > + atomic64_read(&STm->tape->stats->read_cnt)); > + In the interests of time, I just fixed all of this up. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html