On Mon, Jun 1, 2015 at 11:10 AM, Joe Perches <joe@xxxxxxxxxxx> wrote: > On Mon, 2015-06-01 at 10:40 -0500, Bjorn Helgaas wrote: >> Use dev_printk() when possible to make messages more useful. > [] >> diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c > [] >> @@ -268,7 +268,7 @@ mega_query_adapter(adapter_t *adapter) >> raw_mbox[2] = NC_SUBOP_PRODUCT_INFO; /* i.e. 0x0E */ >> >> if ((retval = issue_scb_block(adapter, raw_mbox))) >> - printk(KERN_WARNING >> + dev_warn(&adapter->dev->dev, >> "megaraid: Product_info cmd failed with error: %d\n", >> retval); > > Wouldn't these be a bit redundant with a "megaraid: " prefix now? > Perhaps it'd be nicer to realign arguments too. Yes, you're right. I took out most of the "megaraid: " prefixes, but I missed a few. I tried not to realign things too much because it's hard to know where to stop, and I don't want to spend a week on this. I'll post a v3 in a day or two in case there are other comments. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
