On 05/27/2015 10:19 AM, Narsimhulu Musini wrote: > Kconfig for kbuild > Makefile to build snic module > > Updated MAINTAINERS file > > Signed-off-by: Narsimhulu Musini <nmusini@xxxxxxxxx> > Signed-off-by: Sesidhar Baddela <sebaddel@xxxxxxxxx> > --- > * v3 > - Added additional config section (CONFIG_SNIC_DEBUG_FS) for enabling debugging > functionality. > > * v2 > - Added compile time flags for debugfs dependent functionality. > > MAINTAINERS | 7 +++++++ > drivers/scsi/Kconfig | 17 +++++++++++++++++ > drivers/scsi/Makefile | 1 + > drivers/scsi/snic/Makefile | 21 +++++++++++++++++++++ > 4 files changed, 46 insertions(+) > create mode 100644 drivers/scsi/snic/Makefile > > diff --git a/MAINTAINERS b/MAINTAINERS > index 2a97e05..368fb76 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2536,6 +2536,13 @@ L: linux-scsi@xxxxxxxxxxxxxxx > S: Supported > F: drivers/scsi/fnic/ > > +CISCO SCSI HBA DRIVER > +M: Narsimhulu Musini <nmusini@xxxxxxxxx> > +M: Sesidhar Baddela <sebaddel@xxxxxxxxx> > +L: linux-scsi@xxxxxxxxxxxxxxx > +S: Supported > +F: drivers/scsi/snic/ > + > CMPC ACPI DRIVER > M: Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxxxxxx> > M: Daniel Oliveira Nascimento <don@xxxxxxxxxxx> > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > index 9c92f41..8baab3f 100644 > --- a/drivers/scsi/Kconfig > +++ b/drivers/scsi/Kconfig > @@ -634,6 +634,23 @@ config FCOE_FNIC > <file:Documentation/scsi/scsi.txt>. > The module will be called fnic. > > +config SCSI_SNIC > + tristate "Cisco SNIC Driver" > + depends on PCI && SCSI && X86_64 > + help > + This is support for the Cisco PCI-Express SCSI HBA. > + > + To compile this driver as a module, choose M here and read > + <file:Documentation/scsi/scsi.txt>. > + The module will be called snic. > + > +config SCSI_SNIC_DEBUG_FS > + bool "Cisco SNIC Driver Debugfs Support" > + depends on SCSI_SNIC && DEBUG_FS > + help > + This enables to list debugging information from SNIC Driver > + available via debugfs file system > + > config SCSI_DMX3191D > tristate "DMX3191D SCSI support" > depends on PCI && SCSI > diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile > index 58158f1..f643942 100644 > --- a/drivers/scsi/Makefile > +++ b/drivers/scsi/Makefile > @@ -39,6 +39,7 @@ obj-$(CONFIG_LIBFC) += libfc/ > obj-$(CONFIG_LIBFCOE) += fcoe/ > obj-$(CONFIG_FCOE) += fcoe/ > obj-$(CONFIG_FCOE_FNIC) += fnic/ > +obj-$(CONFIG_SCSI_SNIC) += snic/ > obj-$(CONFIG_SCSI_BNX2X_FCOE) += libfc/ fcoe/ bnx2fc/ > obj-$(CONFIG_ISCSI_TCP) += libiscsi.o libiscsi_tcp.o iscsi_tcp.o > obj-$(CONFIG_INFINIBAND_ISER) += libiscsi.o > diff --git a/drivers/scsi/snic/Makefile b/drivers/scsi/snic/Makefile > new file mode 100644 > index 0000000..572102a > --- /dev/null > +++ b/drivers/scsi/snic/Makefile > @@ -0,0 +1,21 @@ > +obj-$(CONFIG_SCSI_SNIC) += snic.o > + > +snic-y := \ > + snic_attrs.o \ > + snic_main.o \ > + snic_res.o \ > + snic_isr.o \ > + snic_ctl.o \ > + snic_io.o \ > + snic_scsi.o \ > + snic_disc.o \ > + vnic_cq.o \ > + vnic_intr.o \ > + vnic_dev.o \ > + vnic_wq.o > + > +ifeq ($(CONFIG_SCSI_SNIC_DEBUG_FS), y) > +ccflags-y += -DSNIC_DEBUG_FS Why do you need an extra define here just use CONFIG_SCSI_SNIC_DEBUG_FS in source code directly > +snic-y += snic_debugfs.o \ > + snic_trc.o > +endif > snic-$(CONFIG_SCSI_SNIC_DEBUG_FS) += snic_debugfs.o You do not the ifeq () thing at all Cheers Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
