Hi Paul, On Tue, Apr 28, 2015 at 9:10 PM, Paul Bolle <pebolle@xxxxxxxxxx> wrote: > On Tue, 2015-04-28 at 16:15 +0200, Valentin Rothberg wrote: >> CONFIG_ACORNSCSI_CONSTANTS is a file local CPP identifier and thereby >> violates the naming convention of Kconfig options in Make and CPP >> syntax; only Kconfig options should carry the 'CONFIG_' prefix. >> >> This patch removes the 'CONFIG_' prefix to apply to this convention and >> to make static analysis tools happy. > > Will the Erlangen bot still spot ACORNSCSI_CONSTANTS as a potential > issue? No, undertaker-checkpatch won't complain about this. There are thousands of such cases (i.e., without CONFIG_ prefix) around in the code (mostly #ifdef DEBUG). But most of them are intentionally dead or related to debugging, so they are ignored to avoid having false positives. Regards, Valentin > Paul Bolle > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
